feat(agents): carry the provisioning content digest algorithm on the wire - #509
Merged
Conversation
…wire A bare string digest pins the algorithm in a comment and cannot evolve; a Digest value object keeps the contract honest about what committed the bytes and clarifies the placement semantics of parent. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryMedium Risk Overview
Reusing field 6 with a new wire type is intentionally breaking for any prior encodings of this unreleased event; callers must populate and verify Reviewed by Cursor Bugbot for commit 1996b64. Bugbot is set up for automated code reviews on this repo. Configure here. |
WalkthroughThe protobuf contract introduces a required ChangesAgent digest schema
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Code Coverage SummaryDetailsDiff against mainResults for commit: 1996b64 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stringdigest pins the hash algorithm in a comment, so it cannot evolve and forces every consumer to assume SHA-256 by convention; aDigestvalue object keeps the contract self-describing and consistent with how every other digest in the codebase is modeled.parentfield's placement semantics and immutability were implicit; documenting them prevents consumers from mistaking it for a mutable or kinship reference.